Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert additional inputs at random index #40

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Insert additional inputs at random index #40

merged 1 commit into from
Mar 12, 2023

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Mar 1, 2023

Bip78 says re: payjoin proposal: "the additional outputs or additional inputs must be inserted at a random index."

I think it's curious that additional outputs are mentioned. Some people think of payjoins as having exactly two outputs and not a batch of them.

@DanGould
Copy link
Contributor Author

DanGould commented Mar 2, 2023 •
edited
Loading

This may run into the same issues as bitcoindevkit/bdk#871 when we integrate wasm. We could remove the dependency on rand and ask for wasm users to supply their own RNG, but I'd rather just use rand with feature flags. one less decision to make downstream

@DanGould DanGould merged commit 39d5719 into payjoin:master Mar 12, 2023
@DanGould DanGould deleted the rand-input-insert branch February 2, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DanGould